Hello Zoltan Chovan, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19679
to look at the new patch set (#3).
Change subject: [Python] Support setting startup flags in tests
......................................................................
[Python] Support setting startup flags in tests
Currently it is not streamlined, how to set Kudu master, tserver startup
flags in Python tests. This patch adds master_extra_startup_flags() and
tserver_extra_startup_flags() decorators to KuduTestBase in order to
tackle this issue.
The decorators just set the class variables decorator_extra_master_flags
and decorator_extra_tserver_flags. During cluster setup, these are
appended to other default flags, which are hard coded into the Kudu
Python test framework. In the tearDownClass() function, the above lists
need to be wiped, else flags are spilling over from previous test
classes.
In test_common.py a basic test is added, which just starts up and shuts
down a test cluster, without throwing any errors. This is just to check
basic turnaround. If a test developer defines an unknown master flag for
example, the following type of message is raised:
"Exception: Error in response: {'code': 'RUNTIME_ERROR', 'message':
'failed to start masters ... "
In a given test run, after an unsuccessful cluster setup (above line),
chrony is not properly disposed of, and a follow-up test will time out
with error "Another chronyd may already be running". This is blocks
adding negative tests for this patch. I created a jira to track this
issue: KUDU-3464
Change-Id: I2423b29707e58d152aff934908fb3f0400b75da4
---
M python/kudu/tests/common.py
M python/kudu/tests/test_common.py
2 files changed, 74 insertions(+), 18 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/19679/3
--
To view, visit http://gerrit.cloudera.org:8080/19679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I2423b29707e58d152aff934908fb3f0400b75da4
Gerrit-Change-Number: 19679
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <greber...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com>
