Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19690 )
Change subject: KUDU-1945 Add C++ example for non-unique PK ...................................................................... Patch Set 7: Verified+1 (2 comments) unrelated test failure in LogRollingITest.TestLogCleanupOnStartup http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/CMakeLists.txt File examples/cpp/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/CMakeLists.txt@21 PS5, Line 21: set(CMAKE_EXPORT_COMPILE_COMMANDS ON) > Newer IDEs, LSP based completers make heavy use of compile_commands.json. Sure -- let's keep it around if it's useful. http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc File examples/cpp/non_unique_primary_key.cc: http://gerrit.cloudera.org:8080/#/c/19690/5/examples/cpp/non_unique_primary_key.cc@219 PS5, Line 219: ERROR > Sorry about that, thanks for the clarification! No problem. Thanks for the update! -- To view, visit http://gerrit.cloudera.org:8080/19690 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c6be6bece56788dc858468d1fcccff6955836ec Gerrit-Change-Number: 19690 Gerrit-PatchSet: 7 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 13 Apr 2023 16:34:55 +0000 Gerrit-HasComments: Yes
