Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 )
Change subject: [KUDU-3452] Make validate table creating task not affected ...................................................................... Patch Set 19: (4 comments) http://gerrit.cloudera.org:8080/#/c/19594/18//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19594/18//COMMIT_MSG@7 PS18, Line 7: Make validate table creating task not affected > What about: Avoid legitimate tablet creation stagnation due to previous tab Thank you. But this title is too long, over the limitation. http://gerrit.cloudera.org:8080/#/c/19594/18/src/kudu/integration-tests/create-table-itest.cc File src/kudu/integration-tests/create-table-itest.cc: http://gerrit.cloudera.org:8080/#/c/19594/18/src/kudu/integration-tests/create-table-itest.cc@684 PS18, Line 684: string cmd > nit: in is not used. remove it? Done http://gerrit.cloudera.org:8080/#/c/19594/18/src/kudu/integration-tests/create-table-itest.cc@687 PS18, Line 687: rapidjson::Document doc; > nit: tools::RunKuduTool(strings::Split(cmd, " ", strings::SkipEmpty()), &ou Done http://gerrit.cloudera.org:8080/#/c/19594/15/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19594/15/src/kudu/tools/kudu-tool-test.cc@9417 PS15, Line 9417: > Yes. So after that patch committed, you'd better add '--allow_creating_unde OK. I will set this flag after that patch merged. -- To view, visit http://gerrit.cloudera.org:8080/19594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9 Gerrit-Change-Number: 19594 Gerrit-PatchSet: 19 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Wed, 10 May 2023 07:16:49 +0000 Gerrit-HasComments: Yes
