Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19571 )
Change subject: KUDU-3452 Allow creating tablets under replicated tables ...................................................................... Patch Set 23: (3 comments) http://gerrit.cloudera.org:8080/#/c/19571/22/src/kudu/integration-tests/create-table-itest.cc File src/kudu/integration-tests/create-table-itest.cc: http://gerrit.cloudera.org:8080/#/c/19571/22/src/kudu/integration-tests/create-table-itest.cc@647 PS22, Line 647: constexpr int kTSUnresponsiveTimeoutMs = 4000; : constexpr int kHeartbeatIntervalMs = 3000; > Why is the heartbeat interval even longer than tserver unresponsive interva Done http://gerrit.cloudera.org:8080/#/c/19571/17/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/19571/17/src/kudu/master/catalog_manager.cc@6664 PS17, Line 6664: } : > Seems this comment was not resolved in patch set 22. Done http://gerrit.cloudera.org:8080/#/c/19571/17/src/kudu/master/catalog_manager.cc@6677 PS17, Line 6677: let servers are regist > ditto. Done -- To view, visit http://gerrit.cloudera.org:8080/19571 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I742ba1ff770f5c8b1be5800334c29bec96e195c6 Gerrit-Change-Number: 19571 Gerrit-PatchSet: 23 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Fri, 12 May 2023 02:14:52 +0000 Gerrit-HasComments: Yes
