Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19594 )
Change subject: [KUDU-3452] Make validate tablet creating task not affected ...................................................................... Patch Set 24: (2 comments) http://gerrit.cloudera.org:8080/#/c/19594/23/src/kudu/integration-tests/create-table-itest.cc File src/kudu/integration-tests/create-table-itest.cc: http://gerrit.cloudera.org:8080/#/c/19594/23/src/kudu/integration-tests/create-table-itest.cc@782 PS23, Line 782: const > nit: What about using 'constexpr const'? Same as elsewhere. Done http://gerrit.cloudera.org:8080/#/c/19594/23/src/kudu/integration-tests/create-table-itest.cc@801 PS23, Line 801: // Wait until the tablet server become unavailable for replicas placement. > nit: Wait until the tablet server become unavailable for replicas placement Done -- To view, visit http://gerrit.cloudera.org:8080/19594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I64668651d0e8f58b92cfb841bdb20617de6776f9 Gerrit-Change-Number: 19594 Gerrit-PatchSet: 24 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Tue, 16 May 2023 09:20:15 +0000 Gerrit-HasComments: Yes
