Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19874 )
Change subject: KUDU-1945 Add Python example for non-unique PK ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/19874/3/examples/python/basic-python-example/non_unique_primary_key.py File examples/python/basic-python-example/non_unique_primary_key.py: http://gerrit.cloudera.org:8080/#/c/19874/3/examples/python/basic-python-example/non_unique_primary_key.py@142 PS3, Line 142: Updated row(s) WHERE non_unique_key = {0} AND int_val = {1} to int_val = {2}'\ > It's better to change to: 'Updated row(s) int_val = {2} WHERE non_unique_ke I choose to do it this way, such that it matches the cpp example, where we did the same way. https://github.com/apache/kudu/blob/master/examples/cpp/non_unique_primary_key.cc#L278-L279 Is it okay this way, or should i modify anyway? -- To view, visit http://gerrit.cloudera.org:8080/19874 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1dd862c4f26b3d79ec268727363fae3426135f52 Gerrit-Change-Number: 19874 Gerrit-PatchSet: 3 Gerrit-Owner: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Wed, 17 May 2023 16:58:16 +0000 Gerrit-HasComments: Yes
