Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19945 )
Change subject: [util] use include guard macro in int128.h header ...................................................................... [util] use include guard macro in int128.h header Even if '#pragma once' is supported by the vast majority of modern compilers, it is a non-standard one [1]. The src/kudu/util/int128.h file is included into other header files of the C++ Kudu client API, which is supposed to be C++98 compliant. Since other header files in the C++ client API are using include guard macros, let's use the same technique for int128.h as well. Doing so addresses a warning produced by the CLANG when running client_examples_test.sh, while a standalone compilation is done on the kudu/util/int128.h file: #pragma once in main file [-Wpragma-once-outside-header] [1] https://en.cppreference.com/w/cpp/preprocessor/impl Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4 Reviewed-on: http://gerrit.cloudera.org:8080/19783 Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com> Tested-by: Alexey Serbin <ale...@apache.org> Reviewed-on: http://gerrit.cloudera.org:8080/19945 Reviewed-by: Yingchun Lai <laiyingc...@apache.org> Tested-by: Kudu Jenkins Reviewed-by: Yuqi Du <shenxingwuy...@gmail.com> Reviewed-by: Yifan Zhang <chinazhangyi...@163.com> --- M src/kudu/util/int128.h 1 file changed, 5 insertions(+), 1 deletion(-) Approvals: Yingchun Lai: Looks good to me, but someone else must approve Kudu Jenkins: Verified Yuqi Du: Looks good to me, but someone else must approve Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/19945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Ica18bbdc8eff034965e1a69404df2180cacf7bb4 Gerrit-Change-Number: 19945 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com>
