Hello Alexey Serbin, Abhishek Chennaka,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/19958
to review the following change.
Change subject: [client] add -Werror flag for checking client C++ API
......................................................................
[client] add -Werror flag for checking client C++ API
I noticed that many contemporary C++ compilers didn't error out but
issued a warning instead when compiling a code with C++11 features,
even if running with -std=c++98 flag.
To make the API compatibility check more robust, this patch adds -Werror
flag to make sure the client_examples-test.sh fails if incompatibility
is introduced into corresponding header files.
This is a follow-up to 10b1c30441dd48bebf692db8a41464cf08319908.
Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
Reviewed-on: http://gerrit.cloudera.org:8080/19784
Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com>
Tested-by: Alexey Serbin <ale...@apache.org>
---
M src/kudu/client/client_examples-test.sh
1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/58/19958/1
--
To view, visit http://gerrit.cloudera.org:8080/19958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae550774bd0aaf0b7bb8df7e64ee5b8b0fc22ac3
Gerrit-Change-Number: 19958
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
