Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/19951 )
Change subject: Fix OpenSSL3 FIPS_mode() issue on RHEL9.1 ...................................................................... Patch Set 5: Code-Review+1 (1 comment) LGTM, just a minor comment. http://gerrit.cloudera.org:8080/#/c/19951/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19951/5//COMMIT_MSG@13 PS5, Line 13: However : on RHEL9.1 OpenSSL contains a fips.h compatibility header, which maps : the new function to the old FIPS_mode function: Other than RHEL9.1, is there any other distro as well that has this compatibility header present? I guess this change is based on version comparison rather than distro specific. So irrespective of which distro is being used, this will always use FIPS_mode() if version is less than 3 else EVP_default_properties_is_fips_enabled - right ? Just make sure this works for the following cases: 1. OS with OpenSSL >= 3.0 with no compatibility header 2. OS with OpenSSL >= 3.0 with compatibility header 3. OS with OpenSSL < 3.0 with no compatibility header I guess this case won't apply - OS with OpenSSL < 3.0 with compatibility header -- To view, visit http://gerrit.cloudera.org:8080/19951 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib0728846afb07ee937fbe7d99f0057bd8197dd9a Gerrit-Change-Number: 19951 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Fri, 09 Jun 2023 11:12:14 +0000 Gerrit-HasComments: Yes
