Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19620 )
Change subject: KUDU-3459 Download superblock piece by piece ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/19620/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19620/2//COMMIT_MSG@16 PS2, Line 16: tablet_copy_download_superblock_in_batch If the superblock is larger than --rpc_max_message_size, the copy procedure will fail definitely, how about use --rpc_max_message_size to split the superblock by pieces directly? http://gerrit.cloudera.org:8080/#/c/19620/2/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19620/2/src/kudu/tools/kudu-tool-test.cc@8934 PS2, Line 8934: table2 Why create 2 tables? http://gerrit.cloudera.org:8080/#/c/19620/2/src/kudu/tools/kudu-tool-test.cc@8938 PS2, Line 8938: string tablet_ids_str = JoinStrings(mini_cluster_->mini_tablet_server(0)->ListTablets(), ","); Is is necessary to copy multiple tablets? Just copy one tablet is enough IMO. http://gerrit.cloudera.org:8080/#/c/19620/2/src/kudu/tools/kudu-tool-test.cc@8949 PS2, Line 8949: "-tablet_copy_download_superblock_in_batch=true " Can this cover tha case of "superblock size larger than --rpc_max_message_size"? how about set --rpc_max_message_size to a very small value, or increase the superblock size (by adding columns and triggering flush for example) -- To view, visit http://gerrit.cloudera.org:8080/19620 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7c212784383e247566a4701965e2897de83303 Gerrit-Change-Number: 19620 Gerrit-PatchSet: 2 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Mon, 12 Jun 2023 08:51:58 +0000 Gerrit-HasComments: Yes
