Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/19949/11/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19949/11/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@370 PS11, Line 370: belongs nit: belong http://gerrit.cloudera.org:8080/#/c/19949/11/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@371 PS11, Line 371: schema nit: schemas http://gerrit.cloudera.org:8080/#/c/19949/11/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@418 PS11, Line 418: for (Batch batch : batchList) { The batches are put into the list in the same order of operations, so regularly, the last batch may has the same schema with the current operation. To reduce the meaningless loop, it would be better to traverse the list in reverse order, or just judge the last batch in the list. http://gerrit.cloudera.org:8080/#/c/19949/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java: http://gerrit.cloudera.org:8080/#/c/19949/11/java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java@139 PS11, Line 139: 2 typo? -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 11 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Sun, 18 Jun 2023 16:11:52 +0000 Gerrit-HasComments: Yes
