Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20061 )
Change subject: [server] KUDU-1945 Auto_incrementing column UPSERT support ...................................................................... Patch Set 10: (4 comments) http://gerrit.cloudera.org:8080/#/c/20061/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20061/6//COMMIT_MSG@14 PS6, Line 14: With this patch the expected behavior for different operations : from Kudu clients is as follows: > This is hard to parse, please update this to be more readable. Done http://gerrit.cloudera.org:8080/#/c/20061/6//COMMIT_MSG@23 PS6, Line 23: implementati > implementation Done http://gerrit.cloudera.org:8080/#/c/20061/8/src/kudu/tablet/tablet_auto_incrementing-test.cc File src/kudu/tablet/tablet_auto_incrementing-test.cc: http://gerrit.cloudera.org:8080/#/c/20061/8/src/kudu/tablet/tablet_auto_incrementing-test.cc@19 PS8, Line 19: #include <memory> > nit: remove empty line 19 Done http://gerrit.cloudera.org:8080/#/c/20061/8/src/kudu/tablet/tablet_auto_incrementing-test.cc@189 PS8, Line 189: unique_ptr<KuduPartialRow> row(new KuduPartialRow(&client_schema_)); : ASSERT_OK(row->SetInt64(0, INT64_MAX)); : ASSERT_OK(row->SetInt32(1, 1337)); : ASSERT_OK(writer_->Upsert(*row)); : } : { > Thank you for adding these negative scenarios! Done -- To view, visit http://gerrit.cloudera.org:8080/20061 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib5cc4d80f77c165452572948f68c76fc70394d47 Gerrit-Change-Number: 20061 Gerrit-PatchSet: 10 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Fri, 23 Jun 2023 17:41:14 +0000 Gerrit-HasComments: Yes
