Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/19931 )
Change subject: KUDU-3476: Make replica placement range and table aware ...................................................................... Patch Set 8: (2 comments) Did another round of dist-test. The flaky behaviour is found in other places. Just wanted to share the results, as these might help to narrow down the issue. http://gerrit.cloudera.org:8080/#/c/19931/8/src/kudu/master/placement_policy-test.cc File src/kudu/master/placement_policy-test.cc: http://gerrit.cloudera.org:8080/#/c/19931/8/src/kudu/master/placement_policy-test.cc@1063 PS8, Line 1063: ASSERT_EQ(750, stats["ts0"]); More flaky results("../../build-support/dist_test.py loop -n 1000 -- ./bin/placement_policy-test --stress_cpu_threads=16") http://dist-test.cloudera.org/job?job_id=root.1687690260.32277 "14 placement_policy-test.0 dist-test-slave-dist-test-slave-v3hk" [ RUN ] PlacementPolicyTest.PlaceTabletReplicasWithRangesExtremeCase ../../src/kudu/master/placement_policy-test.cc:1063: Failure Expected equality of these values: 750 stats["ts0"] Which is: 751 [ FAILED ] PlacementPolicyTest.PlaceTabletReplicasWithRangesExtremeCase (264 ms) http://gerrit.cloudera.org:8080/#/c/19931/8/src/kudu/master/placement_policy-test.cc@1273 PS8, Line 1273: ASSERT_GE(649, stats[tserver]); More flaky results("../../build-support/dist_test.py loop -n 1000 -- ./bin/placement_policy-test --stress_cpu_threads=16") http://dist-test.cloudera.org/job?job_id=root.1687690260.32277 "9 placement_policy-test.0 dist-test-slave-dist-test-slave-dcxs" [ RUN ] PlacementPolicyTest.PlaceTabletReplicasWithRangesAndTablesWithDoubleTServers ../../src/kudu/master/placement_policy-test.cc:1273: Failure Expected: (649) >= (stats[tserver]), actual: 649 vs 650 [ FAILED ] PlacementPolicyTest.PlaceTabletReplicasWithRangesAndTablesWithDoubleTServers (2897 ms) [----------] 21 tests from PlacementPolicyTest (5504 ms total) -- To view, visit http://gerrit.cloudera.org:8080/19931 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9caeb8d5547e946bfeb152a99e1ec034c3fa0a0f Gerrit-Change-Number: 19931 Gerrit-PatchSet: 8 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com> Gerrit-Comment-Date: Sun, 25 Jun 2023 10:58:50 +0000 Gerrit-HasComments: Yes