Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/20140 )
Change subject: Bump versions in examples to 1.17.0 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20140/1/examples/java/collectl/README.adoc File examples/java/collectl/README.adoc: http://gerrit.cloudera.org:8080/#/c/20140/1/examples/java/collectl/README.adoc@90 PS1, Line 90: spark2_2.11 > Kudu supports two versions: Spark2 and Spark3. In this example, this has t in java/gradle/dependencies.gradle: 10e3cec1 (Attila Bukor 2022-01-19 08:42:55 +0100 57) scala : "2.12.15", 10e3cec1 (Attila Bukor 2022-01-19 08:42:55 +0100 61) spark2 : "2.4.8", 10e3cec1 (Attila Bukor 2022-01-19 08:42:55 +0100 62) spark : "3.1.2", b2039d51 (Grant Henke 2020-10-12 10:08:43 -0500 72) // If the `spark2` property is passed, override the `spark` and `scala` version b2039d51 (Grant Henke 2020-10-12 10:08:43 -0500 73) // to use the `spark2` and `scala211` versions. b2039d51 (Grant Henke 2020-10-12 10:08:43 -0500 74) if (propertyExists("spark2")) { b2039d51 (Grant Henke 2020-10-12 10:08:43 -0500 75) versions["spark"] = "$versions.spark2" b2039d51 (Grant Henke 2020-10-12 10:08:43 -0500 76) versions["scala"] = "$versions.scala211" b2039d51 (Grant Henke 2020-10-12 10:08:43 -0500 77) } b2039d51 (Grant Henke 2020-10-12 10:08:43 -0500 78) e5202d30 (Grant Henke 2017-06-19 09:35:55 -0500 79) // Add base Scala version e5202d30 (Grant Henke 2017-06-19 09:35:55 -0500 80) versions["scalaBase"] = versions.scala.substring(0, versions.scala.lastIndexOf(".")) e5202d30 (Grant Henke 2017-06-19 09:35:55 -0500 81) fa953d05 (Grant Henke 2017-08-16 14:36:47 -0500 82) // Add base Spark version e5202d30 (Grant Henke 2017-06-19 09:35:55 -0500 83) versions["sparkBase"] = versions.spark.substring(0, versions.spark.indexOf(".")) java/kudu-spark/build.gradle: 74b9ac67 (Grant Henke 2019-11-19 15:20:52 -0600 41) archivesBaseName = "kudu-spark${versions.sparkBase}_${versions.scalaBase}" If we use 'spark', its version is "3.1.2" and versions["sparkBase"] is 3. If we use 'spark2', its version is "2.4.8", and versions["sparkBase"] is 2. versions["scalaBase"] are the same which is 2.12, whether spark or spark2. So, spark${versions.sparkBase}_${versions.scalaBase}": kudu-spark3_2.12 if 'spark' kudu-spark2_2.12 if 'spark2' . Right? If spark2, it's kudu-spark2_2.12:1.17.0 ? -- To view, visit http://gerrit.cloudera.org:8080/20140 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: Icf4b023c19de278c52f931574af6029de8de57ec Gerrit-Change-Number: 20140 Gerrit-PatchSet: 1 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Mon, 03 Jul 2023 07:09:29 +0000 Gerrit-HasComments: Yes
