Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20163 )
Change subject: [java client] Make row errors more readable ...................................................................... Patch Set 5: Verified+1 (1 comment) Overall looks good to me, but please fix the LINT errors. You can find the log and understand what gradle tasks to run locally if checking out this Jenkins log: http://jenkins.kudu.apache.org/job/kudu-gerrit/28286/BUILD_TYPE=LINT/console http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java: http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java@103 PS3, Line 103: operation.getRow() > It is better to have all the columns printed out in the error message. It i OK, this sounds good to me. Thank you for the explanation. I guess we aren't concerned with redacting the output information either since that's the client code, and the client's logs can contain sensitive data anyways. -- To view, visit http://gerrit.cloudera.org:8080/20163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1170986ef9b40d83a6b6da8571d15d1c6bf4df97 Gerrit-Change-Number: 20163 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Mon, 31 Jul 2023 18:36:33 +0000 Gerrit-HasComments: Yes
