Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20166 )
Change subject: KUDU-3407 not always flush even if under memory pressure. ...................................................................... Patch Set 9: (8 comments) http://gerrit.cloudera.org:8080/#/c/20166/9//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20166/9//COMMIT_MSG@8 PS9, Line 8: : This patch add an argument to give a chance to do other ops while : server is under memory pressure. : The background of this patch should also be introduced. http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager-test.cc@336 PS9, Line 336: FLAGS_not_flush_memory_prob = 0.0; The default value is 0, why set it again? http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.h@382 PS9, Line 382: /// @param [out] capacity_pct nit: used_memory_percentage http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@104 PS9, Line 104: not_flush_memory_prob It is easy to be understand to use a positive flag. How about: run_non_memory_ops_prob? http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@107 PS9, Line 107: operations to run non-memory operations waiting to be ran. http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@109 PS9, Line 109: This might be needed to turn on if maintainer found " : "that the tablet server is under memory pressure for a long time and " : "the performance is decreasing I think your purpose is to make a balance between running memory and non-memory operations. But It is hard to decide the value of not_flush_memory_prob by the maintainer. How about to computing the not_flush_memory_prob automatically, and using a switch to turn on this feature? http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@111 PS9, Line 111: the performance Reading or wring performance? http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@112 PS9, Line 112: TAG_FLAG(not_flush_memory_prob, experimental); It should also add 'runtime' flag? -- To view, visit http://gerrit.cloudera.org:8080/20166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc2fd3a850cf99d54ef2980211b712468440ed80 Gerrit-Change-Number: 20166 Gerrit-PatchSet: 9 Gerrit-Owner: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Fri, 04 Aug 2023 08:29:20 +0000 Gerrit-HasComments: Yes
