Ashwani Raina has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/20270 )

Change subject: [client] Avoid impala crash by returning error if invalid 
tablet id found
......................................................................


Patch Set 5:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/20270/3//COMMIT_MSG
Commit Message:

PS3:
> We need to have an automated test due to the reasons I described in my prio
I guess it should be trivial.
Ok. Let me update the patch with a unit test.


http://gerrit.cloudera.org:8080/#/c/20270/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/20270/5//COMMIT_MSG@17
PS5, Line 17: Following are the steps to reproduce the issue from impala-shell:
> You can create an issue to record the error and how to reproduce the case.
There is a ticket for this -> KUDU-3461
I will make sure to add that here.



--
To view, visit http://gerrit.cloudera.org:8080/20270
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09cf6fb1b1d10f1ad13a62b5c863bcd1e3ab26a
Gerrit-Change-Number: 20270
Gerrit-PatchSet: 5
Gerrit-Owner: Ashwani Raina <ara...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Comment-Date: Fri, 04 Aug 2023 13:39:36 +0000
Gerrit-HasComments: Yes

Reply via email to