Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20346 )
Change subject: KUDU-3359 Allow multi-JAR cp for Ranger client ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20346/1/src/kudu/ranger/ranger_client.cc File src/kudu/ranger/ranger_client.cc: http://gerrit.cloudera.org:8080/#/c/20346/1/src/kudu/ranger/ranger_client.cc@251 PS1, Line 251: // If the JAR path contains a colon, we skip verifying the paths and leave : // it to Java. : if (ranger_jar_path.find(':') == string::npos && : !Env::Default()->FileExists(ranger_jar_path)) { Would it be a better option to at least log a warning about each particular JAR path that cannot be found when multiple paths are specified with the --ranger_jar_path flag? Of course, the validator would return 'true', but at least it would log a warning. -- To view, visit http://gerrit.cloudera.org:8080/20346 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If137b5541b948506372db50e984eeee7e05dfd22 Gerrit-Change-Number: 20346 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 15 Aug 2023 00:46:07 +0000 Gerrit-HasComments: Yes
