Hello Tidy Bot, Marton Greber, Alexey Serbin, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20365
to look at the new patch set (#11).
Change subject: KUDU-3504 Crash master on subprocess death
......................................................................
KUDU-3504 Crash master on subprocess death
In the past, there were several instances when the Ranger subprocess
crashed. In these cases, the master happily went on, but failed to
authorize requests. Since there's no way to restart the subprocess
without restarting the master anyway, it's better to crash the master as
well to make sure the failure of the subprocess is detected in time and
can be addressed.
Also, a follow-up patch will add the possibility to add extra JVM
arguments, which can easily cause the subprocess to fail to actually
start after forking. Its tests cover this new behavior as well.
As there are multiple concurrent calls to Subprocess::DoWait() now, this
commit also changes some member variables to atomic to make sure it's
thread-safe as TSAN complained about a data race.
Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184
---
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy.h
M src/kudu/util/subprocess.cc
M src/kudu/util/subprocess.h
5 files changed, 58 insertions(+), 17 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/20365/11
--
To view, visit http://gerrit.cloudera.org:8080/20365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184
Gerrit-Change-Number: 20365
Gerrit-PatchSet: 11
Gerrit-Owner: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <greber...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
