Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20484 )
Change subject: [misc] avoid calling vector::resize() right away ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20484/1/src/kudu/tablet/tablet_random_access-test.cc File src/kudu/tablet/tablet_random_access-test.cc: http://gerrit.cloudera.org:8080/#/c/20484/1/src/kudu/tablet/tablet_random_access-test.cc@94 PS1, Line 94: virtual void SetUp() OVERRIDE { > warning: 'virtual' is redundant since the function is already declared 'ove Done http://gerrit.cloudera.org:8080/#/c/20484/1/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/20484/1/src/kudu/util/maintenance_manager.cc@191 PS1, Line 191: completed_ops_count_(0), > warning: field 'completed_ops_count_' will be initialized after field 'comp Done -- To view, visit http://gerrit.cloudera.org:8080/20484 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id72689597c39b66a6f2f24f734a12a90afef152a Gerrit-Change-Number: 20484 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 14 Sep 2023 23:39:53 +0000 Gerrit-HasComments: Yes
