Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 )
Change subject: [KUDU-3447] Limit tablets copying speed ...................................................................... Patch Set 9: (5 comments) http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tools/kudu-tool-test.cc@9359 PS9, Line 9359: NO_FATALS(CreateTableWithFlushedData("table1", mini_cluster_.get(), 3, 1)); : NO_FATALS(CreateTableWithFlushedData("table2", mini_cluster_.get(), 3, 1)); Why create 2 tables? I guess you aim to make both of the 2 tservers have some tablets distributed on them, add some comments to explain this. http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tools/kudu-tool-test.cc@9361 PS9, Line 9361: source_tserver_tablet_count Then check source_tserver_tablet_count doesn't equal to 0. http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tools/kudu-tool-test.cc@9375 PS9, Line 9375: "-tablet_copy_throttler_bytes_per_sec=$4 " : "-tablet_copy_throttler_burst_factor=1 ", The test is just to verify the 2 flags are valid, but dosen't verify the rate limiter works, right? http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tserver/tablet_copy_client.h@355 PS9, Line 355: std::shared_ptr<Throttler> throttler_; I think the LocalTabletCopyClient has the same requirement as well, how about move the throttler_ to the base class TabletCopyClient? http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tserver/tablet_copy_client.cc@1008 PS9, Line 1008: while (!throttler_->Take(MonoTime::Now(), 0, chunk_size)) { How about adding LOG_TIMING when throttle happened? -- To view, visit http://gerrit.cloudera.org:8080/19479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f4834bfb0718a2b6b1d946975287a11f6be1fe3 Gerrit-Change-Number: 19479 Gerrit-PatchSet: 9 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Wed, 20 Sep 2023 03:47:09 +0000 Gerrit-HasComments: Yes
