Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20527 )
Change subject: [Python] KUDU-3353 add support for UPSERT IGNORE ...................................................................... Patch Set 5: (2 comments) http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/client.pyx File python/kudu/client.pyx: http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/client.pyx@3201 PS3, Line 3201: del self.op > Please follow standard python blank line conventions as rest of the file do Done http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/tests/test_client.py File python/kudu/tests/test_client.py: http://gerrit.cloudera.org:8080/#/c/20527/3/python/kudu/tests/test_client.py@530 PS3, Line 530: # successful_upsers++, upsert_ignore_errors++ > nit: remove the extra blank line. Done -- To view, visit http://gerrit.cloudera.org:8080/20527 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9112b96a5688287352307c05e60030a217154cbd Gerrit-Change-Number: 20527 Gerrit-PatchSet: 5 Gerrit-Owner: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 13:02:50 +0000 Gerrit-HasComments: Yes
