Abhishek Chennaka has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20558 )
Change subject: [gutil] fix ASAN warning in CountOnes()
......................................................................
[gutil] fix ASAN warning in CountOnes()
Running various tests on aarch64 (Graviton3) under ASAN produced
warnings like below:
src/kudu/gutil/bits.h:19:42: runtime error: unsigned integer overflow:
134678536 * 16843009 cannot be represented in type 'unsigned int'
#0 0xffffa1ebd8d4 in Bits::CountOnes(unsigned int)
src/kudu/gutil/bits.h:19:42
#1 0xffffa1ebd830 in Bits::CountOnes64(unsigned long)
src/kudu/gutil/bits.h:30:12
#2 0xffffa1ebd7f8 in Bits::CountOnes64withPopcount(unsigned long)
src/kudu/gutil/bits.h:43:12
SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior
src/kudu/gutil/bits.h:19:42
This patch addresses the issue.
Change-Id: I47bff62676ee57706d6b5ef841e3891bba5a62fa
Reviewed-on: http://gerrit.cloudera.org:8080/20558
Reviewed-by: Marton Greber <greber...@gmail.com>
Tested-by: Alexey Serbin <ale...@apache.org>
Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com>
---
M src/kudu/gutil/bits.h
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Marton Greber: Looks good to me, but someone else must approve
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/20558
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I47bff62676ee57706d6b5ef841e3891bba5a62fa
Gerrit-Change-Number: 20558
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <greber...@gmail.com>
Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com>
