Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20559 )
Change subject: [build] bootsreap-dev-env python fix for ubuntu 22.04 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh File docker/bootstrap-dev-env.sh: http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh@a116 PS1, Line 116: Why to remove updating the information on packages available in repo? http://gerrit.cloudera.org:8080/#/c/20559/1/docker/bootstrap-dev-env.sh@116 PS1, Line 116: if [[ $(apt-cache search --names-only '^python$') ]]; then : apt-get install -y --no-install-recommends python I'm not sure this does what it's supposed to do. For example, I have a machine where I got the following output, where python isn't among the packages available: # apt-cache search --names-only '^python$' python-is-python2 - symlinks /usr/bin/python to the DEPRECATED python2 # echo $? 0 With that, the updated script will try to install the 'python', even if it's not available. BTW, how is it supposed to work on, say, Ubuntu20.04? Have you verified it works as expected there? -- To view, visit http://gerrit.cloudera.org:8080/20559 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I275fa06214fde6ede1c6dd8e85f786fdc950cf8c Gerrit-Change-Number: 20559 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Comment-Date: Wed, 11 Oct 2023 18:49:05 +0000 Gerrit-HasComments: Yes
