Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20564 )
Change subject: [rpc] add local address into connection negotiation trace ...................................................................... [rpc] add local address into connection negotiation trace I found it would be easier for RPC connection negotiation troubleshooting to have the information on both the remote and the local addresses of the connection in the negotiation trace. That would help to remove ambiguity when there are multiple Kudu clients running at the same node from which RPC connections are initiated, so now it's easier to find corresponding pairs of negotiation traces in client- and server-side logs. I didn't add any tests, but I manually verified that the information on the local address is present in the connection negotiation traces, for example: 1011 19:59:40.775119 (+ 0us) reactor.cc:618] Submitting negotiation task for client connection to 127.206.101.1:46339 (local address 127.0.0.1:47450) 1011 19:59:40.775135 (+ 0us) reactor.cc:618] Submitting negotiation task for server connection from 127.0.0.1:47450 (local address 127.206.101.1:46339) Change-Id: I2907e9b4fd502e2139c989c940d2f1ac55d23219 Reviewed-on: http://gerrit.cloudera.org:8080/20564 Tested-by: Kudu Jenkins Reviewed-by: Abhishek Chennaka <achenn...@cloudera.com> --- M src/kudu/rpc/reactor.cc 1 file changed, 12 insertions(+), 1 deletion(-) Approvals: Kudu Jenkins: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20564 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I2907e9b4fd502e2139c989c940d2f1ac55d23219 Gerrit-Change-Number: 20564 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Ádám Bakai <aba...@cloudera.com>
