Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19479 )

Change subject: [KUDU-3447] Limit tablets copying speed
......................................................................


Patch Set 18:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/19479/17/src/kudu/tools/tool_action_local_replica.cc
File src/kudu/tools/tool_action_local_replica.cc:

http://gerrit.cloudera.org:8080/#/c/19479/17/src/kudu/tools/tool_action_local_replica.cc@334
PS17, Line 334: shared_ptr<Throttler> throttler;
              :     if (FLAGS_tablet_copy_throttler_bytes_per_sec > 0) {
              :       throttler = std::make_shared<Throttler>(MonoTime::Now(),
              :                                               0,
              :                                               
FLAGS_tablet_copy_throttler_bytes_per_sec,
              :                                               
FLAGS_tablet_copy_throttler_burst_factor);
              :     }
              :
> I doubt different business has different limiting speed. Can replicas migra
We can disable this feature by default, but it would be great to provide the 
ability.
In the senario of Kudu servers are deployed with other IO sensitive servers, it 
would be nice to limit the disk bandwith consumption.
Of cource, you can do this in next patches.



--
To view, visit http://gerrit.cloudera.org:8080/19479
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4834bfb0718a2b6b1d946975287a11f6be1fe3
Gerrit-Change-Number: 19479
Gerrit-PatchSet: 18
Gerrit-Owner: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Wang Xixu <1450306...@qq.com>
Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com>
Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
Gerrit-Comment-Date: Mon, 16 Oct 2023 16:13:32 +0000
Gerrit-HasComments: Yes

Reply via email to