Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20546 )
Change subject: [compaction] Skip memory allocation for ancient undo deltas ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20546/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20546/1//COMMIT_MSG@7 PS1, Line 7: [compaction] Skip memory allocation for ancient undo deltas > Thanks for the review, Alexey. Apologies for being late on this. >From what I can see, the >TabletHistoryGcTest.TestNoGenerateUndoOnMajorDeltaCompaction scenario checks >for different invariants, not something we are interested in with this change. In particular, I'm not sure the following path is covered at all: * A lot of REDO deltas are generated and not yet converted into UNDO deltas because * there is work for minor delta compactions to do * there is work for major delta compactions to do * At some point, those REDO deltas (some of them might be even minor-compacted) become ancient. For example, --tablet_history_max_age_sec is reduced (e.g., that might be the case when tablet server is restarted with tablet_history_max_age_sec set to much lower values than it used to be, with the extreme case of --tablet_history_max_age_sec=1) * Now, all the regular compaction operations are able to run and do their job Let me ask this question: what test scenarios in your opinion do cover the updated functionality to exercise the scenario outlined above? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/20546 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibb41636a3ac063478fe181560d4ec85dadeb0ef3 Gerrit-Change-Number: 20546 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Fri, 20 Oct 2023 17:57:28 +0000 Gerrit-HasComments: Yes
