Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20592 )
Change subject: refactor: move SetEncryptionFlags to constructors ...................................................................... refactor: move SetEncryptionFlags to constructors SetEncryptionFlags() is a test utility function used to enable or disable encryption in unit tests. In some parameterized tests, SetEncryptionFlags() calls are distributed in many test cases, there is a risk that missing to call it if add new test cases. This patch moves the function call to the constructors, also changes TEST_F to TEST_P for test LogBlockManagerTest.TestContainerBlockLimitingByMetadataSizeWithCompaction Change-Id: I67dca5a45f78de87309d0434c3b003a83f28e1a6 Reviewed-on: http://gerrit.cloudera.org:8080/20592 Tested-by: Yingchun Lai <laiyingc...@apache.org> Reviewed-by: Alexey Serbin <ale...@apache.org> --- M src/kudu/consensus/consensus_meta-test.cc M src/kudu/fs/log_block_manager-test.cc M src/kudu/util/file_cache-test.cc 3 files changed, 42 insertions(+), 70 deletions(-) Approvals: Yingchun Lai: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20592 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I67dca5a45f78de87309d0434c3b003a83f28e1a6 Gerrit-Change-Number: 20592 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
