Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20597 )
Change subject: Minor refactors on kudu-tool-test ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20597/3/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/20597/3/src/kudu/tools/kudu-tool-test.cc@273 PS3, Line 273: string args(arg_str); How about redefine `const string& arg_str` to `string arg_str` and use only one variable? -- To view, visit http://gerrit.cloudera.org:8080/20597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5cba40850d2d2ef884f45e252b8117ae12b8f9d9 Gerrit-Change-Number: 20597 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Tue, 24 Oct 2023 08:23:36 +0000 Gerrit-HasComments: Yes
