Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20282 )
Change subject: KUDU-3498 Scanner keeps alive in periodically ...................................................................... Patch Set 18: (1 comment) http://gerrit.cloudera.org:8080/#/c/20282/18/src/kudu/client/scanner-internal.cc File src/kudu/client/scanner-internal.cc: http://gerrit.cloudera.org:8080/#/c/20282/18/src/kudu/client/scanner-internal.cc@107 PS18, Line 107: std::shared_ptr<Messenger> messenger; : RETURN_NOT_OK(builder.Build(&messenger)); Why to instantiate a separate messenger just to send keep-alive requests for a single scanner? Why not to use the messenger used by the client instance (i.e. the messenger built as a part of KuduClientBuilder::Build())? Even if creating a separate messenger here, shouldn't this messenger have the same attributes as the messenger built by KuduClientBuilder::Build()? For example, if a custom SASL protocol name is used for the client's messenger, this keep-alive messenger wouldn't be able to connect unless the correct SASL protocol name is set, I guess. Also, if the client requires authentication, then this messenger must also be created with that property, otherwise it might be a security issue. The same is for the JWT authentication creds, etc. -- To view, visit http://gerrit.cloudera.org:8080/20282 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1165d96814eb4bcd5db9b5cb60403fffc5b18c81 Gerrit-Change-Number: 20282 Gerrit-PatchSet: 18 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 16:31:54 +0000 Gerrit-HasComments: Yes
