Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20613 )
Change subject: Fix a unit test in aarch64 system ...................................................................... Patch Set 4: (7 comments) Just a few nits. http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@10 PS4, Line 10: usually x86 architecture is 4K, but in aarch64 is 64K : in default usually in x86 architecture it is 4k but in aarch64 it is 64k by default. http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@12 PS4, Line 12: runs failed fails http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@13 PS4, Line 13: the a http://gerrit.cloudera.org:8080/#/c/20613/4//COMMIT_MSG@14 PS4, Line 14: using use http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc File src/kudu/fs/log_block_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc@368 PS4, Line 368: system has systems have http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc@369 PS4, Line 369: in by http://gerrit.cloudera.org:8080/#/c/20613/4/src/kudu/fs/log_block_manager-test.cc@369 PS4, Line 369: Therefore, here should Hence use -- To view, visit http://gerrit.cloudera.org:8080/20613 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide52a251b15b1af437d570c146beb0c30fed161b Gerrit-Change-Number: 20613 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Tue, 31 Oct 2023 18:59:52 +0000 Gerrit-HasComments: Yes
