Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20716 )
Change subject: [util] add a warning into 'heap_sample_every_n_bytes' flag description. ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/20716/7/src/kudu/util/flags.cc File src/kudu/util/flags.cc: http://gerrit.cloudera.org:8080/#/c/20716/7/src/kudu/util/flags.cc@100 PS7, Line 100: "in tcmalloc; the lower the value, the higher the lock contention."); Is it necessary to remove the former description? 524288 is a recommend value of the official docs of gperftools[1], it's reasonable to leave it there. 1. https://gperftools.github.io/gperftools/tcmalloc.html -- To view, visit http://gerrit.cloudera.org:8080/20716 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I00d55126f0cad0ac6cc130576cc45808f96f0a47 Gerrit-Change-Number: 20716 Gerrit-PatchSet: 7 Gerrit-Owner: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Comment-Date: Fri, 08 Dec 2023 08:13:30 +0000 Gerrit-HasComments: Yes
