Hello Mahesh Reddy, Yingchun Lai, Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20748
to look at the new patch set (#3).
Change subject: [rpc] micro-optimizations on RpczStore::LogTrace
......................................................................
[rpc] micro-optimizations on RpczStore::LogTrace
This patch micro-optimizes the code in RpczStore::LogTrace():
* faster computation of the logging threshold
* std::string instance is no longer allocated when outputting
the trace of an RPC call
* the LogTrace() method is now static
As an extra style-related change, 'final' specifier has been added to
the RpczStore class' declaration since it was not meant for adding
derived classes on top (its destructor wasn't virtual). Also, switched
samples' timestamp from Atomics to std::atomics and did other unsorted
changes to avoid memory allocation while holding a spinlock and shorten
duration of critical sections overall.
This patch also contains a few nano-optimizations for AsyncLogger class:
* 'final' specifier was added to allow for more run-time optimizations
* unsorted minor changes
Change-Id: I4b9cd537ad9797773f6934ae72d0e865db9770a1
---
M src/kudu/rpc/rpcz_store.cc
M src/kudu/rpc/rpcz_store.h
M src/kudu/util/async_logger.cc
M src/kudu/util/async_logger.h
M src/kudu/util/logging.cc
5 files changed, 79 insertions(+), 72 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/48/20748/3
--
To view, visit http://gerrit.cloudera.org:8080/20748
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I4b9cd537ad9797773f6934ae72d0e865db9770a1
Gerrit-Change-Number: 20748
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com>
Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>
