Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20594 )
Change subject: [Tool] Find file path where the block is stored on ...................................................................... Patch Set 3: (7 comments) http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/fs/block_manager.h@260 PS2, Line 260: > nit: Add some comments for the public APIs. Done http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/fs/block_manager.h@261 PS2, Line 261: le where > The "container" is only use in LogBlockManager, the FileBlockManager does h Done http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/fs/block_manager.h@261 PS2, Line 261: cates in. > nit: const BlockId& block_id Done http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/fs/file_block_manager.cc File src/kudu/fs/file_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/fs/file_block_manager.cc@873 PS2, Line 873: > FYI: FBM has a FindBlockPath(), it's possible to get its path too. OK. I will reuse this interface. http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/fs/log_block_manager.cc@2654 PS2, Line 2654: r()->di > nit: searching ? Done http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/tools/tool_action_local_replica.cc@1220 PS2, Line 1220: } > How about supporting input a list of block ids( the output is a table inste Done http://gerrit.cloudera.org:8080/#/c/20594/2/src/kudu/tools/tool_action_local_replica.cc@1232 PS2, Line 1232: if (!safe_strtou64(bid_str.c_str(), &bid)) { > Return once failed in line 1229. Done -- To view, visit http://gerrit.cloudera.org:8080/20594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ifaafd2bb634ed7fab923d9cf9eef40437442d187 Gerrit-Change-Number: 20594 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 13 Dec 2023 11:54:00 +0000 Gerrit-HasComments: Yes
