Hello Kudu Jenkins, Abhishek Chennaka, I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20772 to look at the new patch set (#3). Change subject: [util] move TCP socket stats into the Socket class ...................................................................... [util] move TCP socket stats into the Socket class This patch moves the protobuf data structures for TCP socket statistics and transport details from src/kudu/rpc/rpc_introspection.proto into src/kudu/util/net/socket_info.proto, separating them into a standalone file. The code that used to retrieve statistics on an RPC connection's TCP socket has been moved into the Socket class correspondingly. With that, it's now possible to collect statistics from a TCP socket which is not yet a transport for any KRPC connection. This also makes it a better design choice if considering the TransportDetailsPB::TlsDetails message since the updated code doesn't need to do the down-casting anymore. These updates are required for follow-up patches with the functionality of collecting TCP statistics for a Socket instance that a Kudu RPC server listens at. Change-Id: I48ba7915f5153bae288b462b07965cdea7b7957b --- M src/kudu/rpc/CMakeLists.txt M src/kudu/rpc/connection.cc M src/kudu/rpc/connection.h M src/kudu/rpc/rpc_introspection.proto M src/kudu/security/CMakeLists.txt M src/kudu/security/tls_socket.cc M src/kudu/security/tls_socket.h M src/kudu/util/CMakeLists.txt M src/kudu/util/net/socket.cc M src/kudu/util/net/socket.h A src/kudu/util/net/socket_info.proto 11 files changed, 343 insertions(+), 314 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/20772/3 -- To view, visit http://gerrit.cloudera.org:8080/20772 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I48ba7915f5153bae288b462b07965cdea7b7957b Gerrit-Change-Number: 20772 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120)