Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20827 )
Change subject: KUDU-3252: Follow up to replica placement bug ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/20827/1/src/kudu/master/placement_policy-test.cc File src/kudu/master/placement_policy-test.cc: http://gerrit.cloudera.org:8080/#/c/20827/1/src/kudu/master/placement_policy-test.cc@1568 PS1, Line 1568: // This test is more granular and specifically tests SelectReplica() and its > It would be great to add a small comment to describe the essence of this te Done http://gerrit.cloudera.org:8080/#/c/20827/1/src/kudu/master/placement_policy-test.cc@1569 PS1, Line 1569: h > That's quite uncommon replication factor, and usually even replication fact Changed the replication factor to 3, I was mostly just trying to test out the different tiebreaker scenarios. http://gerrit.cloudera.org:8080/#/c/20827/1/src/kudu/master/placement_policy-test.cc@1569 PS1, Line 1569: vari > nit: could use 'constexpr' here? Done http://gerrit.cloudera.org:8080/#/c/20827/1/src/kudu/util/random_util.h File src/kudu/util/random_util.h: http://gerrit.cloudera.org:8080/#/c/20827/1/src/kudu/util/random_util.h@84 PS1, Line 84: result->clear() > Why to have this if k is already of uint32_t type? Isn't it true for every Oops brain fart, fixed it. -- To view, visit http://gerrit.cloudera.org:8080/20827 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86 Gerrit-Change-Number: 20827 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Sat, 23 Dec 2023 07:07:50 +0000 Gerrit-HasComments: Yes
