Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/18569 )
Change subject: KUDU-3371 [fs] Use RocksDB to store LBM metadata ...................................................................... Patch Set 61: (6 comments) http://gerrit.cloudera.org:8080/#/c/18569/61//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/18569/61//COMMIT_MSG@50 PS61, Line 50: contructed nit: constructed http://gerrit.cloudera.org:8080/#/c/18569/61//COMMIT_MSG@52 PS61, Line 52: Contruct nit: Construct http://gerrit.cloudera.org:8080/#/c/18569/61//COMMIT_MSG@56 PS61, Line 56: logr "logr" a little short and not clear. use 'rocksdb' directly? http://gerrit.cloudera.org:8080/#/c/18569/61/src/kudu/fs/fs_report.h File src/kudu/fs/fs_report.h: http://gerrit.cloudera.org:8080/#/c/18569/61/src/kudu/fs/fs_report.h@291 PS61, Line 291: corrupted_rdb_record_check This field seems no used. So add a TODO? http://gerrit.cloudera.org:8080/#/c/18569/61/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: http://gerrit.cloudera.org:8080/#/c/18569/61/src/kudu/fs/log_block_manager.cc@2093 PS61, Line 2093: tmp_key = Substitute("$0.$1", id_, lb->block_id().ToString()); this statement happens several times in this file, may be a simple function to construct this key is better. http://gerrit.cloudera.org:8080/#/c/18569/61/src/kudu/fs/log_block_manager.cc@4035 PS61, Line 4035: key(e.block_id); Should this key be id + "." + block_id ? -- To view, visit http://gerrit.cloudera.org:8080/18569 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie72f6914eb5653a9c034766c6cd3741a8340711f Gerrit-Change-Number: 18569 Gerrit-PatchSet: 61 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Sat, 23 Dec 2023 15:59:47 +0000 Gerrit-HasComments: Yes
