Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana ...................................................................... Patch Set 1: (3 comments) Thank you for working on a blog post! That's been quite long time since last blog posted at Apache Kudu website. http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md File _posts/2023-12-18-kudu-prometheus-grafana.md: http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@18 PS1, Line 18: JMX format I'm not sure what 'JMX format' means, but I might be missing something. Could you provide a few references, so I could learn about the 'JMX format'? As we discussed offline already, I don't think mentioning JMX framework is quite relevant in this context. If there is an idea to point that there is no need to perform any transformations for Kudu metrics produced by the '/metrics' kudu-master/kudu-tserver endpoints, let's do so in a more generic way, maybe? If it's desirable to add more specifics (which I'm not sure about, frankly: why to so that in this blog?), maybe mention a few common ways how people usually build bridges between metric sources of arbitrary formats and Prometheus. But mentioning only the JMX framework (which is Java-specific) seems to be irrelevant both to Prometheus as a consumer (Go) and Kudu server-side as a producer (C++). http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@17 PS1, Line 17: to add : custom jars Add custom JARs where? http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@172 PS1, Line 172: can create a script which parses the TServer addresses Consider mentioning KUDU-3538: ideally, Kudu masters could implement HTTP Service Discovery for Prometheus. Once implemented, it will be enough to specify the SD URL(s) in the Prometheus config file. Alternatively, you could try to implement that trivial enhancement first, and then update this blog post :) -- To view, visit http://gerrit.cloudera.org:8080/20814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: gh-pages Gerrit-MessageType: comment Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f Gerrit-Change-Number: 20814 Gerrit-PatchSet: 1 Gerrit-Owner: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Comment-Date: Wed, 03 Jan 2024 04:10:48 +0000 Gerrit-HasComments: Yes
