Hello Alexey Serbin,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/20861

to review the following change.


Change subject: KUDU-3252: Follow up to replica placement bug
......................................................................

KUDU-3252: Follow up to replica placement bug

This patch addresses the feedback left on
patch [1].

ReservoirSample is refactored to accept an
unsigned integer rather than a signed integer.

A new test is added to verify the functionality
of the tiebreaker scenarios of
PlacementPolicy::SelectReplica().

[1] https://github.com/apache/kudu/commit/a84c8376a

Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Reviewed-on: http://gerrit.cloudera.org:8080/20827
Tested-by: Alexey Serbin <ale...@apache.org>
Reviewed-by: Alexey Serbin <ale...@apache.org>
(cherry picked from commit 2810e635cc72aa5279a9dc787b6becad6e0098a9)
---
M src/kudu/master/placement_policy-test.cc
M src/kudu/master/placement_policy.cc
M src/kudu/util/random_util.h
3 files changed, 68 insertions(+), 21 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/61/20861/1
--
To view, visit http://gerrit.cloudera.org:8080/20861
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I28582cae538ca27fa26fbfae84460b3b264ddb86
Gerrit-Change-Number: 20861
Gerrit-PatchSet: 1
Gerrit-Owner: Mahesh Reddy <mre...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>

Reply via email to