Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20715 )
Change subject: KUDU-3526 [java] Scanner should bind with a tserver in java client. ...................................................................... Patch Set 25: (4 comments) > Patch Set 25: > > (2 comments) Thanks for the review. I am kind of confused since I think the notes there are already trying to explain why to call RemoteTablet.demoteLeader and AsyncClient.emptyTabletsCacheForTable. The two methods are used to simulate the scenario. http://gerrit.cloudera.org:8080/#/c/20715/25//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20715/25//COMMIT_MSG@10 PS25, Line 10: bound > nit: bind was correct Done http://gerrit.cloudera.org:8080/#/c/20715/23/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20715/23/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@294 PS23, Line 294: > nit: this is not necessary in Java Done http://gerrit.cloudera.org:8080/#/c/20715/23/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20715/23/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@678 PS23, Line 678: // with a not leader exception. And the retry of the request will refresh the tablets > IIUC this is what triggered the bug before your fix, correct? Can you add a Yes, and added some details. http://gerrit.cloudera.org:8080/#/c/20715/25/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20715/25/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java@676 PS25, Line 676: // This exception happens when a scanner is opened and then the leader of the tablet > The wording is a bit confusing, as there is no exception right now, only be The words are trying to describe the process without the fix. Actually I think this is not necessary, the following paragraph is enough. -- To view, visit http://gerrit.cloudera.org:8080/20715 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9cf65f4215e99198dd41b43d14e50c8c23b8a9b2 Gerrit-Change-Number: 20715 Gerrit-PatchSet: 25 Gerrit-Owner: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Mon, 08 Jan 2024 08:16:44 +0000 Gerrit-HasComments: Yes
