Hello Tidy Bot, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20868
to look at the new patch set (#3).
Change subject: KUDU-3543 Fix Content-Type headers
......................................................................
KUDU-3543 Fix Content-Type headers
This patch addresses an issue with the webserver's the Content-Headers.
The problem is that in the webserver's path handler functions we only
use a bool called 'is_styled' to decide on the style mode [1].
This patch basically replaces the 'is_styled' bool with the StyleMode
enum entirely. I added test cases to check the Content-Type headers of
Master and TServer endpoints.
[1]
https://github.com/apache/kudu/blob/master/src/kudu/server/webserver.cc#L671-L672
Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f
---
M src/kudu/master/master-test.cc
M src/kudu/master/master_path_handlers.cc
M src/kudu/server/default_path_handlers.cc
M src/kudu/server/pprof_path_handlers.cc
M src/kudu/server/rpcz-path-handler.cc
M src/kudu/server/startup_path_handler.cc
M src/kudu/server/tracing_path_handlers.cc
M src/kudu/server/webserver.cc
M src/kudu/server/webserver.h
M src/kudu/tserver/tablet_server-test.cc
M src/kudu/tserver/tserver_path_handlers.cc
M src/kudu/util/jwt-util-test.cc
M src/kudu/util/mini_oidc.cc
M src/kudu/util/test_util.h
M src/kudu/util/thread.cc
M src/kudu/util/web_callback_registry.h
16 files changed, 218 insertions(+), 82 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/20868/3
--
To view, visit http://gerrit.cloudera.org:8080/20868
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I746dcfbaadb2fb95292c2d4047cb7adb9971b42f
Gerrit-Change-Number: 20868
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <greber...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <ale...@apache.org>
Gerrit-Reviewer: Attila Bukor <abu...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <greber...@gmail.com>
Gerrit-Reviewer: Tidy Bot (241)
