Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20875 )
Change subject: Use GTEST_SKIP() to skip tests ...................................................................... Use GTEST_SKIP() to skip tests GTEST_SKIP() is better than manually logging and return, the former is able to print hint messages and the skipped tests in summaries, for example: $ bin/fs_manager-test --gtest_filter=*TestAddRemoveDataDirs* ... [ RUN ] BlockManagerTypes/FsManagerTestBase.TestAddRemoveDataDirs/0 ... Skipping test, file block manager not supported [ SKIPPED ] BlockManagerTypes/FsManagerTestBase.TestAddRemoveDataDirs/0 (10 ms) ... [==========] 12 tests from 1 test suite ran. (6407 ms total) [ PASSED ] 6 tests. [ SKIPPED ] 6 tests, listed below: [ SKIPPED ] BlockManagerTypes/FsManagerTestBase.TestAddRemoveDataDirs/0 [ SKIPPED ] BlockManagerTypes/FsManagerTestBase.TestAddRemoveDataDirs/1 [ SKIPPED ] BlockManagerTypes/FsManagerTestBase.TestAddRemoveDataDirs/2 [ SKIPPED ] BlockManagerTypes/FsManagerTestBase.TestAddRemoveDataDirsFuzz/0 [ SKIPPED ] BlockManagerTypes/FsManagerTestBase.TestAddRemoveDataDirsFuzz/1 [ SKIPPED ] BlockManagerTypes/FsManagerTestBase.TestAddRemoveDataDirsFuzz/2 Change-Id: Id3c39255e97cfc67a8cb8d01f8aefa74d570e786 Reviewed-on: http://gerrit.cloudera.org:8080/20875 Tested-by: Yingchun Lai <laiyingc...@apache.org> Reviewed-by: Alexey Serbin <ale...@apache.org> --- M src/kudu/cfile/cfile-test.cc M src/kudu/fs/block_manager-test.cc M src/kudu/fs/fs_manager-test.cc M src/kudu/integration-tests/ts_recovery-itest.cc M src/kudu/rpc/rpc-test.cc M src/kudu/server/webserver-test.cc M src/kudu/tablet/compaction-test.cc M src/kudu/tablet/tablet-decoder-eval-test.cc M src/kudu/tools/ksck_remote-test.cc M src/kudu/tools/kudu-tool-test.cc M src/kudu/tserver/tablet_server-test.cc M src/kudu/util/env-test.cc M src/kudu/util/interval_tree-test.cc M src/kudu/util/logging-test.cc M src/kudu/util/minidump-test.cc M src/kudu/util/test_util.h 16 files changed, 51 insertions(+), 63 deletions(-) Approvals: Yingchun Lai: Verified Alexey Serbin: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20875 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id3c39255e97cfc67a8cb8d01f8aefa74d570e786 Gerrit-Change-Number: 20875 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org>