Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20761 )
Change subject: [Java] KUDU-3498 Scanner keeps alive in periodically ...................................................................... Patch Set 4: (5 comments) http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@481 PS3, Line 481: client.stopKeepAlivePeriodically(); > Should we also call stopKeepAlivePeriodically in the close() function? Yes, you are right. http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@967 PS3, Line 967: l > nit: can be Done http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java File java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java: http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/main/java/org/apache/kudu/client/KuduScanner.java@112 PS3, Line 112: ca > nit: can be Done http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java: http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@424 PS3, Line 424: // the keep-alive timer will be cancelled. > Could we also verify that the KeepAlive task has been stopped automatically Done http://gerrit.cloudera.org:8080/#/c/20761/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java@461 PS3, Line 461: Timeout keepAliveTimeout = (Timeout)field.get(asyncClient); : assertFalse(keepAliveTimeout.isCancelled()); > Could you add a comment why we do this? Done -- To view, visit http://gerrit.cloudera.org:8080/20761 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I50648e987b72aead472a20ff4336e3e7f23d8e06 Gerrit-Change-Number: 20761 Gerrit-PatchSet: 4 Gerrit-Owner: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Comment-Date: Mon, 15 Jan 2024 04:06:24 +0000 Gerrit-HasComments: Yes
