Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20822 )
Change subject: KUDU-3535 Clear log cache while tombstoning a replica. ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/20822/8/src/kudu/consensus/consensus_queue-test.cc File src/kudu/consensus/consensus_queue-test.cc: http://gerrit.cloudera.org:8080/#/c/20822/8/src/kudu/consensus/consensus_queue-test.cc@1194 PS8, Line 1194: a replica is tombstoned Would it better to create a replica and tombstone it, then verify that it's log cache will be cleared? http://gerrit.cloudera.org:8080/#/c/20822/8/src/kudu/consensus/consensus_queue.h File src/kudu/consensus/consensus_queue.h: http://gerrit.cloudera.org:8080/#/c/20822/8/src/kudu/consensus/consensus_queue.h@379 PS8, Line 379: FRIEND_TEST(ConsensusQueueTest, ClearLogCacheWhileClosing); It is better to put it in dictionary order. -- To view, visit http://gerrit.cloudera.org:8080/20822 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cf545e604f80d41e7ebd9660acfd2e928cd27a9 Gerrit-Change-Number: 20822 Gerrit-PatchSet: 8 Gerrit-Owner: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Mon, 29 Jan 2024 09:07:23 +0000 Gerrit-HasComments: Yes
