Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20816 )
Change subject: [compaction] Add tests to generate high memory rowset compaction ...................................................................... Patch Set 9: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20816/6/src/kudu/tablet/compaction-test.cc File src/kudu/tablet/compaction-test.cc: http://gerrit.cloudera.org:8080/#/c/20816/6/src/kudu/tablet/compaction-test.cc@637 PS6, Line 637: // into consideration the amount of free memory left and based on > The problem with setting FLAGS_memory_limit_hard_bytes in the test is that Yep, with the initialization g_hard_limit it's quite limiting, indeed. Alternatively, you could separate these tests into their own binary, if it makes sense. It's up to you -- if you are quite confident this approach is good enough with updated thresholds, then I'm OK with this approach. Anyway, if after pushing this patch it starts failing from time to time, it will be necessary to reconsider this approach. -- To view, visit http://gerrit.cloudera.org:8080/20816 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1996558e71c49314c6acf12faf854c796548318c Gerrit-Change-Number: 20816 Gerrit-PatchSet: 9 Gerrit-Owner: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 30 Jan 2024 05:51:34 +0000 Gerrit-HasComments: Yes
