Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21006
Change subject: [test] a small clean-up on StringGaugePrometheusTest ...................................................................... [test] a small clean-up on StringGaugePrometheusTest I took a quick look at KUDU-3549, and a natural first step was to check whether we have a proper test coverage for handling StringGauge in when dumping metrics in Prometheus format. The result was this patch, adding a couple new sub-scenarios into MetricsTest.StringGaugePrometheusTest. While this didn't lead to discovering the root case of the reported issue, the new sub-scenarios are still useful since they provide extra coverage for the related functionality. I also took the liberty of cleaning up the code a bit. Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Reviewed-on: http://gerrit.cloudera.org:8080/20984 Reviewed-by: Yingchun Lai <laiyingc...@apache.org> Tested-by: Alexey Serbin <ale...@apache.org> (cherry picked from commit ce8ef84d9cf1c4aca8edd07920dfef274edb8df4) --- M src/kudu/util/metrics-test.cc 1 file changed, 43 insertions(+), 33 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/06/21006/1 -- To view, visit http://gerrit.cloudera.org:8080/21006 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: newchange Gerrit-Change-Id: Ie495f3bae91facd98e9ce61ee86f34dea8b08087 Gerrit-Change-Number: 21006 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <ale...@apache.org>
