Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21027 )
Change subject: Revert "KUDU-3371 [fs] Use RocksDB to store LBM metadata" ...................................................................... Patch Set 7: > > Patch Set 6: Code-Review+2 > > > > > Patch Set 6: Code-Review+2 > > > > > > It seems Yingchun on a 10-day vacation, so awaiting +2 from him > on this patch soon isn't viable. > > > > > > From what I can see, he wasn't against reverting this patch > temporarily, at least that's what he mentioned in a Slack chat: > > > > > > > > > Alexey Serbin > > > 9:16 AM > > > Thanks a lot, Yingchun! If you aren't able to resolve it > shortly, are you OK with temporarily rollick back the change if > it's indeed breaks a few things? Just in case, though (I hope we > can fix the issues quite soon, though). > > > > > > Yingchun Lai > > > 9:34 AM > > > Sorry about this, I'll revert it tomorrow temporarily. > > > > Yes, Alexey and Marton have informed me about this issue, feel > free to revert it if you found serious issues, I'm on a vacation > and have not much time to take care about this. > > > > It would be nice if you provide more issue details, it's helpful > for troubleshooting and fixing it, thanks. > > Thanks for the info, will do some troubleshooting. > Just wanted to get a green build on the revert, but failed to do > so. > Thats why I havent submitted the revert yet. > I'm going to dig around today to find out if these are just flakies > in the above failed runs, or another patch is the culprit. > Things are little bit slow as the flaky dashboard is also not > functioning. > Will keep this thread posted. In my case, dist-test failed with SIGILL while trying to run many test binaries with this patch. Once I reverted this patch, no failures due to SIGILL, and most times all tests passes. That was when I compiled Kudu tests in DEBUG configuration on CentOS 7.9 -- To view, visit http://gerrit.cloudera.org:8080/21027 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I792b4b9d775e60a301a01d9af81d7a0955e4ce2c Gerrit-Change-Number: 21027 Gerrit-PatchSet: 7 Gerrit-Owner: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: KeDeng <kdeng...@gmail.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <greber...@gmail.com> Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Reviewer: Yifan Zhang <chinazhangyi...@163.com> Gerrit-Reviewer: Yingchun Lai <laiyingc...@apache.org> Gerrit-Reviewer: Yuqi Du <shenxingwuy...@gmail.com> Gerrit-Comment-Date: Wed, 14 Feb 2024 02:19:50 +0000 Gerrit-HasComments: No
