Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21127 )
Change subject: WIP [ARM] Concurrent binary tree memory fences fixed. ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21127/3//COMMIT_MSG@43 PS3, Line 43: the fences > did you mean "absence of fences"? base::subtle::Release_Store(v, *v | BTREE_INSERTING_MASK); Is in practice equivalent to: Lazy_Store(v, *v | BTREE_INSERTING_MASK); std::atomic_thread_fence(std::memory_order_release) Or with std::atomic<int> v, it would be equivalent to: v->fetch_or(BTREE_SPLITTING_MASK, std:: memory_order_release); I should have written "constraints are not sufficient". I will change it. -- To view, visit http://gerrit.cloudera.org:8080/21127 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie7c02dc3b9444599ef680fa9b29ae7a4d39dd382 Gerrit-Change-Number: 21127 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Zoltan Martonka <zmarto...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Mar 2024 14:36:33 +0000 Gerrit-HasComments: Yes
