Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21030 )
Change subject: [wip][build] KUDU-3551 Upgrade gradle to 7.6.4 ...................................................................... Patch Set 5: (5 comments) Just a few quite random comments. I haven't taken a proper look at this patch yet. http://gerrit.cloudera.org:8080/#/c/21030/5//COMMIT_MSG Commit Message: PS5: It would be great to include the references to the Gradle documentation that you used to find information on deprecated configurations, mappings between the old/deprecated ones and the new ones, etc. http://gerrit.cloudera.org:8080/#/c/21030/5/java/build.gradle File java/build.gradle: http://gerrit.cloudera.org:8080/#/c/21030/5/java/build.gradle@a61 PS5, Line 61: Shouldn't this become 'implementation' as per docs at https://docs.gradle.org/current/userguide/upgrading_version_6.html ? Or the original designation of this to be a 'compile' configuration was not correct? http://gerrit.cloudera.org:8080/#/c/21030/5/java/kudu-subprocess/build.gradle File java/kudu-subprocess/build.gradle: http://gerrit.cloudera.org:8080/#/c/21030/5/java/kudu-subprocess/build.gradle@64 PS5, Line 64: implementation libs.yetusAnnotations Could this be 'compileOnly' as well? http://gerrit.cloudera.org:8080/#/c/21030/5/java/kudu-test-utils/build.gradle File java/kudu-test-utils/build.gradle: http://gerrit.cloudera.org:8080/#/c/21030/5/java/kudu-test-utils/build.gradle@24 PS5, Line 24: style nit: this isn't consistent with the rest of the code in this file -- there isn't a space between a parenthesis elsewhere, even in the newly added shadowJar block at lines 60-67 http://gerrit.cloudera.org:8080/#/c/21030/5/java/kudu-test-utils/build.gradle@54 PS5, Line 54: implementation libs.async What is this for and why it appeared only while upgrading to Gradle7? Would be great to add a comment. -- To view, visit http://gerrit.cloudera.org:8080/21030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I915dab011aba633d55a79c72ea6f459d703d7f47 Gerrit-Change-Number: 21030 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Chovan <zcho...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 20 Mar 2024 01:10:58 +0000 Gerrit-HasComments: Yes
