Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/21227 )
Change subject: KUDU-3562 fix integer overflow in available space metrics
......................................................................
KUDU-3562 fix integer overflow in available space metrics
This patch addresses KUDU-3562. The problem was in implicit casting
of 64-bit integers down to 32-bit ones when introducing a helper
variable in CalculateAvailableSpace(). A new test scenario is added
to cover the fixed issue and catch regressions in future, if any.
In addition, this patch corrects the type of the related metrics in
disk_failure-itest.cc. It also clarifies on the description and tags
of the --fs_{data_dirs,wal_dir}_available_space_cache_seconds flags.
Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Reviewed-on: http://gerrit.cloudera.org:8080/21227
Reviewed-by: Abhishek Chennaka <[email protected]>
Tested-by: Abhishek Chennaka <[email protected]>
Reviewed-by: Mahesh Reddy <[email protected]>
---
M src/kudu/fs/data_dirs.cc
M src/kudu/integration-tests/disk_failure-itest.cc
M src/kudu/integration-tests/disk_reservation-itest.cc
M src/kudu/server/server_base.cc
4 files changed, 109 insertions(+), 14 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved; Verified
Mahesh Reddy: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/21227
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I974aea822626e4648886388c0de3741ac459f2ec
Gerrit-Change-Number: 21227
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
